Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(coachmark): adds 80% coverage tests threshold #6530

Conversation

AlexanderMelox
Copy link
Contributor

@AlexanderMelox AlexanderMelox commented Dec 3, 2024

Closes #6262
Screenshot 2024-12-03 at 3 04 57 PM

This PR increases coachmark coverage

What did you change?

How did you test and verify your work?

Ran tests and coverage report

@AlexanderMelox AlexanderMelox requested a review from a team as a code owner December 3, 2024 20:03
@AlexanderMelox AlexanderMelox requested review from makafsal and amal-k-joy and removed request for a team December 3, 2024 20:03
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit f1b5e41
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/675b5129b2d74200085ad358
😎 Deploy Preview https://deploy-preview-6530--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit f1b5e41
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/675b5129b5273a0007df3065
😎 Deploy Preview https://deploy-preview-6530--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewgallo matthewgallo changed the title tests(coachmark): adds 80% coverage tests threshold test(coachmark): adds 80% coverage tests threshold Dec 3, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.78%. Comparing base (36bd4f9) to head (f1b5e41).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6530      +/-   ##
==========================================
+ Coverage   80.06%   80.78%   +0.72%     
==========================================
  Files         394      394              
  Lines       12907    12872      -35     
  Branches     4277     4265      -12     
==========================================
+ Hits        10334    10399      +65     
+ Misses       2573     2473     -100     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

amal-k-joy
amal-k-joy previously approved these changes Dec 9, 2024
Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewgallo matthewgallo removed the status: percy 🦔 This PR is waiting for a Percy check label Dec 9, 2024
@matthewgallo matthewgallo added this pull request to the merge queue Dec 13, 2024
Merged via the queue into carbon-design-system:main with commit 1174a16 Dec 13, 2024
33 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Coachmark code coverage
5 participants